Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixer:vod] relax _VALID_URL (fixes #21531) #21536

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Conversation

mikf
Copy link
Contributor

@mikf mikf commented Jun 26, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Changed the _VALID_URL regex pattern to match new VOD URLs as seen in #21531
e.g. https://mixer.com/Midgalicis?vod=IxFno1rqC0S_XJ1a2yGgNw

@987computer
Copy link

987computer commented Jun 27, 2019

I recompiled it with the updated py file and it seems to have worked well. Hope this fix comes with the next officially released version.

@dstftw dstftw merged commit 6625bf2 into ytdl-org:master Jun 27, 2019
@mikf mikf deleted the mixer_pattern branch June 27, 2019 15:35
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants