Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yandexmusic] extract tracks from all volumes of an album (closes #21420) #21421

Merged
merged 6 commits into from
Jul 13, 2019

Conversation

aerworker
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

An album in yandex music can have several volumes. Tracks from all volumes should be extracted.

Copy link
Collaborator

@dstftw dstftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract also track_number and disk_number.

@aerworker
Copy link
Contributor Author

aerworker commented Jun 21, 2019

@dstftw Done

@dstftw dstftw merged commit c452790 into ytdl-org:master Jul 13, 2019
Lamieur referenced this pull request in Lamieur/youtube-dl Aug 3, 2019
…ber and disk number (closes #21420) (#21421)

* [yandexmusic] extract tracks from all volumes of an album (closes #21420)

* [yandexmusic] extract genre, disk_number and track_number

* [yandexmusic] extract decomposed artist names

* Update yandexmusic.py

* Update yandexmusic.py

* Update yandexmusic.py
meunierd referenced this pull request in meunierd/youtube-dl Feb 13, 2020
…ber and disk number (closes #21420) (#21421)

* [yandexmusic] extract tracks from all volumes of an album (closes #21420)

* [yandexmusic] extract genre, disk_number and track_number

* [yandexmusic] extract decomposed artist names

* Update yandexmusic.py

* Update yandexmusic.py

* Update yandexmusic.py
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
…rack number and disk number (closes #21420) (#21421)"

This reverts commit 7904ee5.
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
…rack number and disk number (closes #21420) (#21421)"

This reverts commit 7904ee5.
pareronia referenced this pull request in pareronia/youtube-dl Jun 22, 2020
…ber and disk number (closes #21420) (#21421)

* [yandexmusic] extract tracks from all volumes of an album (closes #21420)

* [yandexmusic] extract genre, disk_number and track_number

* [yandexmusic] extract decomposed artist names

* Update yandexmusic.py

* Update yandexmusic.py

* Update yandexmusic.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants