[BrightcoveNew] Add playlist support #21331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylepw
changed the title
kylepw
force-pushed
the
bcplaylist
branch
6 times, most recently
from
3df6bcd to
8d6685b
Compare
|
@dstftw Could you take a look at this? It's not much new code. I'd really like to add BC playlist support. Thanks! |
|
Does not seem to work. must extract playlist of 7 video entries not a single video with all playlist entries dumped as formats. |
@dstftw Okay, it extracts playlists now. How is this? |
dstftw
requested changes
Jun 22, 2019
|
@dstftw I made the requested changes. Please confirm. |
meunierd
referenced
this pull request
in meunierd/youtube-dl
Dec 27, 2019
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
I added support for playlist streams to BrightcoveNewIE, including an additional test. Only differences between 'playlist' and 'video' streams are the 'xxxId' part of the URL and the format of the JSON response, both of which are covered in this PR.