Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pornhub] Download over HTTPS #21061

Merged
merged 1 commit into from
May 22, 2019
Merged

[pornhub] Download over HTTPS #21061

merged 1 commit into from
May 22, 2019

Conversation

NRTICN
Copy link
Contributor

@NRTICN NRTICN commented May 11, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

ATM, youtube-dl downloads over HTTP, even though HTTPS is specified in the URL (because user wants to download over HTTPS as ISP has blocked HTTP access to the site 😞). So just download over HTTPS.

I have checked #20314 and tested downloading the mentioned playlist URL in the source code, and seems to work.

@dstftw dstftw merged commit 2c53c0e into ytdl-org:master May 22, 2019
meunierd referenced this pull request in meunierd/youtube-dl Dec 27, 2019
meunierd referenced this pull request in meunierd/youtube-dl Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants