-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[piksel] add subtitle capability (e.g. https://player.piksel.com/v/ums2867l) #20506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remitamine
reviewed
Mar 31, 2019
chuckcho
force-pushed
the
piksel-subtitles
branch
from
August 7, 2019 22:43
89cf94b
to
2a219aa
Compare
remitamine
reviewed
Aug 8, 2019
chuckcho
force-pushed
the
piksel-subtitles
branch
2 times, most recently
from
August 15, 2019 17:33
aea791a
to
74d75e0
Compare
the test doesn't pass:
|
chuckcho
force-pushed
the
piksel-subtitles
branch
from
August 15, 2019 20:41
74d75e0
to
1ec3757
Compare
fixed
|
Thanks. |
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Added subtitle feature for
piksel
, e.g. now supportingyoutube-dl --write-sub --sub-lang en --skip-download 'https://player.piksel.com/v/ums2867l'