Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common:opengraph] Don't fail on missing title (fixes #18590) #19202

Closed
wants to merge 1 commit into from
Closed

[common:opengraph] Don't fail on missing title (fixes #18590) #19202

wants to merge 1 commit into from

Conversation

bitraid
Copy link
Contributor

@bitraid bitraid commented Feb 12, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This small change only adds a default 'untitled' value to OpenGraph title so it won't fail when it's missing.
Closes #18590

@dstftw
Copy link
Collaborator

dstftw commented Feb 12, 2019

No, this is expected behavior. Client code must pass default on its own.

@dstftw dstftw closed this Feb 12, 2019
@dstftw dstftw added the invalid label Feb 12, 2019
@bitraid bitraid deleted the opengraph-untitled branch February 12, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: Unable to extract OpenGraph title;
2 participants