Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert archive.org thumbnail url to absolute (Closes #18892) #18895

Closed

Conversation

seasoprano
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Thumbnail URL from archive.org is no longer absolute path as detailed in #18892 . This PR checks for the path and convert it into absolute.

Copy link
Collaborator

@dstftw dstftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urljoin.

Copy link
Collaborator

@dstftw dstftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed in _parse_jwplayer_data.

@seasoprano
Copy link
Author

This should be fixed in _parse_jwplayer_data.

Should I override that method then call super and modify the return value?

@dstftw
Copy link
Collaborator

dstftw commented Jan 17, 2019

No. Again: it must be fixed in InfoExtractor._parse_jwplayer_data.

@seasoprano seasoprano closed this Jan 17, 2019
@seasoprano seasoprano deleted the fix-archive.org-thumbnail branch January 17, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants