[YouPorn] Make title regex more specific. #18748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe to drop _search_regex? _og_search_title also finds the correct title.
dstftw
requested changes
Jan 8, 2019
youtube_dl/extractor/youporn.py
Outdated
| #r'<h1[^>]+class=["\']heading\d?["\'][^>]*>(?P<title>[^<]+)<', | ||
| ], webpage, 'title', group='title', default=None) \ | ||
| or self._og_search_title(webpage, default=None) \ | ||
| or self._html_search_meta('title', webpage, fatal=True) |
There was a problem hiding this comment.
Don't touch code formatting.
youtube_dl/extractor/youporn.py
Outdated
| title = self._search_regex([ | ||
| r'[=:]\s*(["\'])video[\._-]titles?\1[^>]*>\s*<\s*h1[^>]+class=["\']heading\d?["\'][^>]*>(?P<title>[^<]+)<', | ||
| r'(?:video_titles|videoTitle)\s*[:=]\s*(["\'])(?P<title>(?:(?!\1).)+)\1', | ||
| #r'<h1[^>]+class=["\']heading\d?["\'][^>]*>(?P<title>[^<]+)<', |
dstftw
requested changes
Jan 8, 2019
| default=None) or self._og_search_title( | ||
| webpage, default=None) or self._html_search_meta( | ||
| 'title', webpage, fatal=True) | ||
| title = self._og_search_title(webpage, default=None) or self._html_search_meta('title', webpage, fatal=True) |
There was a problem hiding this comment.
Do not remove _search_regex part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the title regex matches too many blocks, and finds
Recommended Categories For Youin stead of the actual title.Safe to drop
_search_regex?_og_search_titlealso finds the correct title.