Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[toutv] fixes #16398 - accounts don't work after site redesign. #18700

Closed
wants to merge 1 commit into from

Conversation

alexhuot1
Copy link
Contributor

@alexhuot1 alexhuot1 commented Dec 31, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

fixes #16398
Tou.tv was redesign with react and the login url was moved into JS. The code was not able to find the clientID needed.
My fix browses through the app.js file to extract the clientID needed for the login form.

@alexhuot1 alexhuot1 changed the title [toutv] Corrects issue #16398 - account don't work after redesign. [toutv] (Closes #16398) - accounts don't work after site redesign. Dec 31, 2018
@alexhuot1 alexhuot1 changed the title [toutv] (Closes #16398) - accounts don't work after site redesign. [toutv] (fixes #16398) - accounts don't work after site redesign. Dec 31, 2018
@alexhuot1 alexhuot1 changed the title [toutv] (fixes #16398) - accounts don't work after site redesign. [toutv] fixes #16398 - accounts don't work after site redesign. Dec 31, 2018
@tabarnakos
Copy link

Hey kudos for the fix !

I am new as of today to youtube-dl, but it worked flawlessly after doing a checkout of your toutv_account branch.

@alexhuot1
Copy link
Contributor Author

Do you need anymore changes? Thanks

@mos8580
Copy link

mos8580 commented Jan 15, 2019

I tried running this branch and while it seems I can login, there is an error afterwards.

[debug] Command-line args: ['-u', 'PRIVATE', 'https://ici.tou.tv/l-insaisissable-carcajou/S01E01?lectureauto=1', '--verbose']
Type account password and press [Return]:
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.12.17
[debug] Git HEAD: 5b2fdda
[debug] Python version 3.7.2 (CPython) - Darwin-18.2.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.1, ffprobe 4.1
[debug] Proxy map: {}
[tou.tv] Downloading app.js script
[tou.tv] Downloading login page
[tou.tv] Logging in
[tou.tv] Following Redirection
[tou.tv] Extracting Claims
ERROR: Unable to download JSON metadata: HTTP Error 598: Unknown (caused by <HTTPError 598: 'Unknown'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

@alexhuot1
Copy link
Contributor Author

Weird, i just tried it and it worked. Looked like the server send a timeout error. Maybe give it another go. I notice tou.tv seems to have server issues recently.

Bonne chance!

@mos8580
Copy link

mos8580 commented Jan 15, 2019

Weird, i just tried it and it worked. Looked like the server send a timeout error. Maybe give it another go. I notice tou.tv seems to have server issues recently.

Bonne chance!

Franchement, j'aurais pu essayer deux fois... ça fonctionne bien, merci! =)

@alexhuot1
Copy link
Contributor Author

@dstftw Is there any reason why this PR in not getting merge?

@m-p-3
Copy link

m-p-3 commented Feb 6, 2019

Sent my account info to @remitamine, hope this will help.

@remitamine remitamine closed this in 8fecc73 Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't download from a tou.tv account. Site redesigned!
5 participants