Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ads embedded in json if any (closes #18430) #18474

Closed
wants to merge 2 commits into from

Conversation

adirizka7
Copy link

@adirizka7 adirizka7 commented Dec 9, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

The issue on http://rudo.video is on some videos it has ads. When the program tries to parse the js with js_to_json it caused error because the 'events' key which was produced from ads has several js function as its value and program can't parse it as usual. I made a change to the code so when there's an 'events' key matched it will be removed. Hopefully, it won't cause any problem to the ad-free one because the ad-free videos does't have the 'events' key. CMIIW. Hope this solves #18430 .

Lamieur referenced this pull request in Lamieur/youtube-dl Aug 3, 2019
meunierd referenced this pull request in meunierd/youtube-dl Feb 13, 2020
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
pareronia referenced this pull request in pareronia/youtube-dl Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant