Add age-limit option on dailymotion to download explicit #18437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, any news on this PR? This one may help us on a problem we're having on Dailymotion for the past few weeks. |
mdaniel
reviewed
Jul 10, 2019
| if (17 < age_limit) : | ||
| metadata_url = update_url_query( | ||
| 'https://www.dailymotion.com/player/metadata/video/%s' | ||
| % video_id, {}) |
There was a problem hiding this comment.
By far the better solution is to pull the extra dict out into a variable guarded by this if rather than duplicating the "meat" of that call; something like:
if 17 < age_limit:
metadata_extra = {}
else:
metadata_extra = {
'embedder': url,
'integration': 'inline',
'GK_PV5_NEON': '1',
}
metadata_url = update_url_query(
'https://www.dailymotion.com/player/metadata/video/%s'
% video_id, metadata_extra)| 'integration': 'inline', | ||
| 'GK_PV5_NEON': '1', | ||
| }) | ||
| if (17 < age_limit) : |
There was a problem hiding this comment.
Please continue to make the code PEP8 compliant, which the extra space between the condition and the : violate, as does the extra space between your else and : below
The parens around the test are also unnecessary, but I don't believe they're strictly speaking wrong
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
- extract http formats included in m3u8 manifest - fix user extraction(closes #3553)(closes #21415) - add suport for User Authentication(closes #11491) - fix password protected videos extraction(closes #23176) - respect age limit option and family filter cookie value(closes #18437) - handle video url playlist query param - report alowed countries for geo-restricted videos
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
- extract http formats included in m3u8 manifest - fix user extraction(closes #3553)(closes #21415) - add suport for User Authentication(closes #11491) - fix password protected videos extraction(closes #23176) - respect age limit option and family filter cookie value(closes #18437) - handle video url playlist query param - report alowed countries for geo-restricted videos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
#18398 On Dailymotion, you can't download Explicit Content without cookie. It's because metadata page has GET params which raises error. If you remove these params, you can download. So, I added test on age_limit CLI option to generate good url. (Sorry, I'm not Python developer, I hope no bullshit in my little add)