Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrktv] add additional URL scheme for episodes #18387

Closed
wants to merge 1 commit into from

Conversation

barsnick
Copy link

@barsnick barsnick commented Dec 3, 2018

Series' episodes seem to have gained an additional URL scheme. This
expands the valid URL for NRKTVEpisodeIE.

A test was also added, but it fails due to a proper update of the
EPISODE_RE. (The existing test also fails, so d'uh.)

NRKTVSeriesIE may also need to be adapted.

Fixes #18304

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Add another URL scheme for episodes. Description above and in commit message.

Series' episodes seem to have gained an additional URL scheme. This
expands the valid URL for NRKTVEpisodeIE.

A test was also added, but it fails due to a proper update of the
EPISODE_RE. (The existing test also fails, so d'uh.)

NRKTVSeriesIE may also need to be adapted.

Fixes g3/youtube-dl#18304
@dstftw dstftw closed this in 33cc1ea Dec 6, 2018
@abdallahalsamman
Copy link

@dstftw This was not merged? can we know the reasoning behind closing without being merging?

@barsnick
Copy link
Author

barsnick commented Dec 6, 2018

@dstftw This was not merged? can we know the reasoning behind closing without being merging?

This was fixed with a commit similar to mine, not with a merge:
33cc1ea

Fine by me if it works. Will test later (but I assume the author already did).

@abdallahalsamman
Copy link

@barsnick cool, I hope it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRK Nett-Tv
2 participants