Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gfycat] update json api endpoint #18343

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Conversation

JimmStout
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

Fixes #18333

Based on the suggestions on the issue page, I changed the URL for the JSON api, and now, the Gfycat tests are passing:

youtube-dl$ python test/test_download.py TestDownload.test_Gfycat
[Gfycat] DeadlyDecisiveGermanpinscher: Downloading video info
[info] Writing video description metadata as JSON to: test_Gfycat_DeadlyDecisiveGermanpinscher.info.json
[debug] Invoking downloader on u'https://fat.gfycat.com/DeadlyDecisiveGermanpinscher.mp4'
[download] Destination: test_Gfycat_DeadlyDecisiveGermanpinscher.mp4
[download] 100% of 10.00KiB in 00:00
.
----------------------------------------------------------------------
Ran 1 test in 1.832s

OK
youtube-dl$ python test/test_download.py TestDownload.test_Gfycat_1
[Gfycat] JauntyTimelyAmazontreeboa: Downloading video info
[info] Writing video description metadata as JSON to: test_Gfycat_1_JauntyTimelyAmazontreeboa.info.json
[debug] Invoking downloader on u'https://zippy.gfycat.com/JauntyTimelyAmazontreeboa.mp4'
[download] Destination: test_Gfycat_1_JauntyTimelyAmazontreeboa.mp4
[download] 100% of 10.00KiB in 00:00
.
----------------------------------------------------------------------
Ran 1 test in 1.902s

OK

@dstftw dstftw merged commit 16597c2 into ytdl-org:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gfycat cajax json endpoint is gone
2 participants