Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON as on 27.11.2018 #18320

Closed
wants to merge 1 commit into from
Closed

Fix JSON as on 27.11.2018 #18320

wants to merge 1 commit into from

Conversation

SpEcHiDe
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

When the HotStar website was visited today, the JSON key seemed to have a changed.

image

Hence edited the one word in the code.

@dstftw
Copy link
Collaborator

dstftw commented Nov 27, 2018

PS C:\Dev\youtube-dl\master> py -3.6 -W error .\test\test_download.py TestDownload.test_HotStar
[hotstar] 1000076273: Downloading webpage
[hotstar] 1000076273: Downloading JSON metadata
[hotstar] 1000076273: Downloading m3u8 information
[info] Writing video description metadata as JSON to: test_HotStar_1000076273.info.json
.
----------------------------------------------------------------------
Ran 1 test in 6.333s

OK

Provide concrete example URLs of what this is supposed to fix.

@SpEcHiDe
Copy link
Contributor Author

SpEcHiDe commented Nov 28, 2018

Please try with this URL: https://www.hotstar.com/1000057157 as shown in the screenshot.

@dstftw
Copy link
Collaborator

dstftw commented Nov 29, 2018

This change breaks current test as it has the old layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants