Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tiktok] Add new extractor #18135

Closed
wants to merge 7 commits into from
Closed

[tiktok] Add new extractor #18135

wants to merge 7 commits into from

Conversation

Flat
Copy link
Contributor

@Flat Flat commented Nov 9, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Provides an extractor for ((v)m).tiktok.com closes #18108

@dstftw
Copy link
Collaborator

dstftw commented Nov 10, 2018

Read coding conventions and fix code.

@Flat
Copy link
Contributor Author

Flat commented Nov 10, 2018

I believe you were referring to optional fields being fatal (using an index which may not exist). The latest commit should remedy that. Let me know if I missed anything else.

@dstftw
Copy link
Collaborator

dstftw commented Nov 10, 2018

Nothing conceptually changed.

@Flat
Copy link
Contributor Author

Flat commented Nov 10, 2018

I hope this is now more in-line with the code conventions.

youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Show resolved Hide resolved
@Flat
Copy link
Contributor Author

Flat commented Nov 10, 2018

youtube_dl/extractor/tiktok.py Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tiktok.py Outdated Show resolved Hide resolved
@dstftw dstftw closed this in ce18a19 Dec 1, 2018
@Flat
Copy link
Contributor Author

Flat commented Dec 1, 2018

Sorry it took so long to get into a semi-mergable state. Thank you for the reviews and ultimately implementing and improving the extractor. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site request tiktok.com
2 participants