-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tiktok] Add new extractor #18135
[tiktok] Add new extractor #18135
Conversation
Read coding conventions and fix code. |
I believe you were referring to optional fields being fatal (using an index which may not exist). The latest commit should remedy that. Let me know if I missed anything else. |
Nothing conceptually changed. |
I hope this is now more in-line with the code conventions. |
I've added all available formats and get the extension in a similar fashion to https://github.com/rg3/youtube-dl/blob/c3bcd206eb031de30179c88ac7acd806a477ceae/youtube_dl/extractor/hearthisat.py#L106-L111 and https://github.com/rg3/youtube-dl/blob/c3bcd206eb031de30179c88ac7acd806a477ceae/youtube_dl/extractor/wdr.py#L75-L78 as the downloads URLs do not provide a file extension. |
Sorry it took so long to get into a semi-mergable state. Thank you for the reviews and ultimately implementing and improving the extractor. Cheers. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Provides an extractor for ((v)m).tiktok.com closes #18108