Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atv.at] fix initial video extraction #18044

Merged

Conversation

NeroBurner
Copy link
Contributor

@NeroBurner NeroBurner commented Nov 1, 2018

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

ATV.at did change the HTML structure. They moved the json data into a
variable. Now the extractor looks for the variable instead

Fixes: #18041

@NeroBurner NeroBurner changed the title atv.at: fix initial video extraction [atv.at] fix initial video extraction Nov 1, 2018
youtube_dl/extractor/atvat.py Outdated Show resolved Hide resolved
@NeroBurner NeroBurner force-pushed the atv_at_fix_initial_video_extraction branch from 528f6fa to 05c0766 Compare November 3, 2018 09:39
@NeroBurner
Copy link
Contributor Author

@dstftw fixed, please recheck pending-fixes label

youtube_dl/extractor/atvat.py Outdated Show resolved Hide resolved
youtube_dl/extractor/atvat.py Outdated Show resolved Hide resolved
ATV.at did change the HTML structure. They moved the json data into a
variable. Now the extractor looks for the variable instead

Also keep the old regex
@NeroBurner NeroBurner force-pushed the atv_at_fix_initial_video_extraction branch from 05c0766 to b948314 Compare November 5, 2018 19:26
@NeroBurner
Copy link
Contributor Author

@dstftw fixed and also checked with flake8, please reevaluate

@NeroBurner
Copy link
Contributor Author

@dstftw please review

@dstftw dstftw merged commit 0919cd4 into ytdl-org:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ATV.at failed to parse JSON
2 participants