[orf] fixes extraction of video formats #18024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use _extract_m3u8_formats and _extract_f4m_formats helper functions closes #17737
Khang-NT
referenced
this pull request
in Khang-NT/youtube-dl
Nov 7, 2018
* 'master' of https://github.com/rg3/youtube-dl: (186 commits) release 2018.11.07 [ChangeLog] Actualize [ci skip] [youtube] Add another JS signature function name regex (closes #18091, closes #18093, closes #18094) [facebook] fix tahoe request(closes #17171) [cliphinter] Fix extraction (closes #18083) [youtube:playlist] Add support for invidio.us (closes #18077) [osnateltv] Update host [zattoo] Arrange API hosts for derived extractors (closes #18035) [README.md] Improve documentation on safe metadata extraction and add more examples [youtube] Add fallback metadata extraction from videoDetails (closes #18052) release 2018.11.03 [ChangeLog] Actualize [ci skip] [laola1tv:embed] Set correct stream access URL scheme (closes #16341) [ehftv] Add extractor (closes #15408) [azmedien] Simplify (closes #17746) [azmedien] Adopt to major site redesign (closes #17745) [extractor/common] Ensure response handle is not prematurely closed before it can be read if it matches expected_status (resolves #17195, closes #17846, resolves #17447) [twitcasting] Improve extraction and fix issues (closes #17981) [twitcasting] Add extractor [orf:tvthek] Improve extraction and remove unused code (closes #17956, closes #18024) ...
lkho
referenced
this pull request
in lkho/youtube-dl
Dec 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
m3u8 and f4m URLs were handled as normal files.
use
_extract_m3u8_formatsand_extract_f4m_formatsto generate correct format structures. (closes #17737)