Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SnapchatStory] Add new extractor #17631

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[SnapchatStory] Add new extractor #17631

wants to merge 4 commits into from

Conversation

Tatsh
Copy link
Contributor

@Tatsh Tatsh commented Sep 22, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Add new extractor for Snapchat stories in the web player.

youtube_dl/extractor/extractors.py Outdated Show resolved Hide resolved
youtube_dl/extractor/snapchat.py Outdated Show resolved Hide resolved
youtube_dl/extractor/snapchat.py Outdated Show resolved Hide resolved
youtube_dl/extractor/snapchat.py Outdated Show resolved Hide resolved
youtube_dl/extractor/snapchat.py Outdated Show resolved Hide resolved
youtube_dl/extractor/snapchat.py Outdated Show resolved Hide resolved
@sdushantha
Copy link

Would it be possible to add support to map.snapchat.com links?

You can take a look at this repo which supports this type of link.
https://github.com/notcammy/PySnapStories/blob/master/pysnapstories.py

@Tatsh
Copy link
Contributor Author

Tatsh commented Sep 30, 2018

I added support for those links. The test uses State College, Pennsylvania.

@Tatsh
Copy link
Contributor Author

Tatsh commented Jan 26, 2019

@dstftw Please review again since the last commit.

@Tatsh
Copy link
Contributor Author

Tatsh commented Mar 20, 2019

Bump

@Tatsh Tatsh requested a review from dstftw November 28, 2019 04:19
@dstftw dstftw force-pushed the master branch 2 times, most recently from 7b956a1 to 5e26784 Compare September 13, 2020 13:51
@Tatsh
Copy link
Contributor Author

Tatsh commented Nov 17, 2020

@dstftw If you want me to make changes, I'll need to re-make this PR. I asked GitHub and they cannot fix branch references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants