Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PornHub] Add support for non-verified pornstar video collections (fixes issue #16078) #17454

Closed
wants to merge 12 commits into from

Conversation

parmjitv
Copy link
Contributor

@parmjitv parmjitv commented Sep 7, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Updated the extractor for Pornhub.com to also provide support for non-verified pornstar videos as playlists - issue #16078.

Cheers and thank you!

Parmjit V.

@dstftw
Copy link
Collaborator

dstftw commented Sep 8, 2018

Does not properly work for https://www.pornhub.com/model/zoe_ph.

@parmjitv
Copy link
Contributor Author

parmjitv commented Sep 9, 2018

@dstftw - Good catch! Looks like the itertools loop spins indefinitely when a paginator is not present in the page source, the latest commit should fix that.

@parmjitv
Copy link
Contributor Author

@dstftw - Would it be possible to have a second review of this PR? I believe the revised fix for this issue is pretty straightforward. Much appreciated!

@parmjitv
Copy link
Contributor Author

@dstftw - Are any collaborators available for a second review? I believe this PR would be a very useful improvement, as there are still quite a few non-verified pornstar profiles active on the Pornhub website. Thank you!

@parmjitv
Copy link
Contributor Author

@remitamine @yan12125 Would it be possible to have a second review of this PR? I believe this to be a useful fix as users are still having difficulty when trying to fetch playlists of videos - see issue #17936 for example. Many thanks in advance!

@parmjitv
Copy link
Contributor Author

parmjitv commented Nov 1, 2018

@dstftw - One more respectful request to please have this PR reviewed. The Pornhub site is quite popular and this PR will resolve a number of outstanding issues currently open - namely #16078, #17936 and #11922. The fix is simple, and resolving this PR may help to prevent duplicate issues from being opened in the future. Thank you very much!

@github-userx
Copy link

@parmjitv Any update on this? After all these months the pornhub user videos downloader from ytdl still doesn’t work..?

@github-userx
Copy link

@dstftw Any update on the pornhub user videos extractor/downloader?

@parmjitv
Copy link
Contributor Author

@github-userx - The collaborators did not provide any further feedback for this PR. Unfortunate, as it would have resolved a number of open issues.

@parmjitv
Copy link
Contributor Author

@github-userx - Due to some recent changes on the PH website, this pull request requires some additional work for pagination. It seems unlikely this PR will be reviewed further by the collaborators so I am not going to bother with updating - please feel free to pick this up yourself if you like.

Cheers,

Parmjit V.

@dstftw dstftw closed this in 21b0846 Jun 21, 2019
@ytdl-org ytdl-org deleted a comment from dirsigler Nov 16, 2019
@ytdl-org ytdl-org locked and limited conversation to collaborators Nov 16, 2019
meunierd referenced this pull request in meunierd/youtube-dl Dec 27, 2019
meunierd referenced this pull request in meunierd/youtube-dl Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants