-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PornHub] Add support for non-verified pornstar video collections (fixes issue #16078) #17454
Conversation
Does not properly work for https://www.pornhub.com/model/zoe_ph. |
@dstftw - Good catch! Looks like the itertools loop spins indefinitely when a paginator is not present in the page source, the latest commit should fix that. |
@dstftw - Would it be possible to have a second review of this PR? I believe the revised fix for this issue is pretty straightforward. Much appreciated! |
@dstftw - Are any collaborators available for a second review? I believe this PR would be a very useful improvement, as there are still quite a few non-verified pornstar profiles active on the Pornhub website. Thank you! |
@remitamine @yan12125 Would it be possible to have a second review of this PR? I believe this to be a useful fix as users are still having difficulty when trying to fetch playlists of videos - see issue #17936 for example. Many thanks in advance! |
@dstftw - One more respectful request to please have this PR reviewed. The Pornhub site is quite popular and this PR will resolve a number of outstanding issues currently open - namely #16078, #17936 and #11922. The fix is simple, and resolving this PR may help to prevent duplicate issues from being opened in the future. Thank you very much! |
@parmjitv Any update on this? After all these months the pornhub user videos downloader from ytdl still doesn’t work..? |
@dstftw Any update on the pornhub user videos extractor/downloader? |
@github-userx - The collaborators did not provide any further feedback for this PR. Unfortunate, as it would have resolved a number of open issues. |
@github-userx - Due to some recent changes on the PH website, this pull request requires some additional work for pagination. It seems unlikely this PR will be reviewed further by the collaborators so I am not going to bother with updating - please feel free to pick this up yourself if you like. Cheers, Parmjit V. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Updated the extractor for Pornhub.com to also provide support for non-verified pornstar videos as playlists - issue #16078.
Cheers and thank you!
Parmjit V.