[wwe] Add extractor #17450
Closed
[wwe] Add extractor #17450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Should resolve issue #14781. |
dstftw
requested changes
Sep 8, 2018
youtube_dl/extractor/wwe.py
Outdated
| player = drupal_settings['WWEVideoLanding']['initialVideo'] | ||
| metadata = player['playlist'][0] | ||
|
|
||
| title = metadata.get('title') |
There was a problem hiding this comment.
Read coding conventions on mandatory and optional meta fields.
youtube_dl/extractor/wwe.py
Outdated
| metadata = player['playlist'][0] | ||
|
|
||
| title = metadata.get('title') | ||
| video_url = 'https:' + metadata.get('file') |
youtube_dl/extractor/wwe.py
Outdated
|
|
||
| title = metadata.get('title') | ||
| video_url = 'https:' + metadata.get('file') | ||
| thumbnail = 'https://www.wwe.com' + metadata.get('image') |
youtube_dl/extractor/wwe.py
Outdated
| thumbnail = 'https://www.wwe.com' + metadata.get('image') | ||
| description = metadata.get('description') | ||
|
|
||
| id = re.split('[/.]', video_url)[-2] |
|
Added a commit resolving the issues. |
dstftw
requested changes
Sep 8, 2018
youtube_dl/extractor/wwe.py
Outdated
| metadata = player['playlist'][0] | ||
|
|
||
| if metadata.get('file') is None: | ||
| raise ExtractorError('Unable to extract video url') |
There was a problem hiding this comment.
video_url = 'https:' + metadata['file'] ?
youtube_dl/extractor/wwe.py
Outdated
| video_url = 'https:' + metadata.get('file') | ||
| thumbnail = None | ||
| if metadata.get('image') is not None: | ||
| thumbnail = 'https://www.wwe.com' + metadata.get('image') |
youtube_dl/extractor/wwe.py
Outdated
| thumbnail = 'https://www.wwe.com' + metadata.get('image') | ||
| description = metadata.get('description') | ||
|
|
||
| id = self._generic_id(video_url) |
There was a problem hiding this comment.
Nothing changed. Also there is a video id available in JSON.
youtube_dl/extractor/wwe.py
Outdated
| 'ext': 'mp4', | ||
| 'title': 'Daniel Bryan vs. Andrade "Cien" Almas: SmackDown LIVE, Sept. 4, 2018', | ||
| 'description': 'Still fuming after he and his wife Brie Bella were attacked by The Miz and Maryse last week, Daniel Bryan takes care of some unfinished business with Andrade "Cien" Almas.', | ||
| 'thumbnail': 'https://www.wwe.com/f/styles/wwe_16_9_s/public/2018/09/20180904_sd_danielalmas--d97661dd31eea8a99837a3dbc7121f8f.jpg', |
| 'id': 'sd994_bryan_almas_090418', | ||
| 'ext': 'mp4', | ||
| 'title': 'Daniel Bryan vs. Andrade "Cien" Almas: SmackDown LIVE, Sept. 4, 2018', | ||
| 'description': 'Still fuming after he and his wife Brie Bella were attacked by The Miz and Maryse last week, Daniel Bryan takes care of some unfinished business with Andrade "Cien" Almas.', |
|
I addressed the requested changes in the latest commit from 2 weeks ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
The extractor adds support for wwe.com videos