Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aparat] Fixed extractor of Aparat with new updates #17445

Closed
wants to merge 2 commits into from

Conversation

airani
Copy link
Contributor

@airani airani commented Sep 5, 2018

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense(provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

It's a fix bug pull request for extractor of Aparat about new updates in this source

@airani airani changed the title Fixed extractor of Aparat with new updates [Aparat] Fixed extractor of Aparat with new updates Sep 5, 2018
@dstftw
Copy link
Collaborator

dstftw commented Sep 8, 2018

Have you even tried running it?

> py -3.6 .\youtube_dl\__main__.py http://www.aparat.com/v/wP8On -F
[Aparat] wP8On: Downloading webpage
Traceback (most recent call last):
  File ".\youtube_dl\__main__.py", line 19, in <module>
    youtube_dl.main()
  File "C:\Dev\youtube-dl\master\youtube_dl\__init__.py", line 472, in main
    _real_main(argv)
  File "C:\Dev\youtube-dl\master\youtube_dl\__init__.py", line 462, in _real_main
    retcode = ydl.download(all_urls)
  File "C:\Dev\youtube-dl\master\youtube_dl\YoutubeDL.py", line 2001, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "C:\Dev\youtube-dl\master\youtube_dl\YoutubeDL.py", line 792, in extract_info
    ie_result = ie.extract(url)
  File "C:\Dev\youtube-dl\master\youtube_dl\extractor\common.py", line 502, in extract
    ie_result = self._real_extract(url)
  File "C:\Dev\youtube-dl\master\youtube_dl\extractor\aparat.py", line 46, in _real_extract
    for item in file_list['plugins']['sabaPlayerPlugin']['multiSRC'][1]:
IndexError: list index out of range

@airani
Copy link
Contributor Author

airani commented Sep 8, 2018

You're right, actually I tested with the other URL that works! sorry, I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants