Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picarto improvements #16518

Closed
wants to merge 3 commits into from
Closed

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented May 21, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

These are just some minor fixes that fixes watching private streams.

TingPing added 3 commits May 21, 2018 17:13
This is just more reliable than trying to extract
it from the page itself.
This is just unreliable and some streams like private
ones do not work via this method.
@dstftw dstftw closed this in 730c0d1 Nov 11, 2018
@TingPing
Copy link
Contributor Author

TingPing commented Nov 11, 2018

@dstftw The referenced commit doesn't even do everything this PR did...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant