-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flixel] Add new extractor #14899
[Flixel] Add new extractor #14899
Conversation
return { | ||
'id': video_id, | ||
'title': meta.get('caption'), | ||
'url': meta.get('hd_mp4'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More video qualities are available.
meta = self._download_json(json_url, video_id) | ||
return { | ||
'id': video_id, | ||
'title': meta.get('caption'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title is mandatory.
'title': meta.get('caption'), | ||
'url': meta.get('hd_mp4'), | ||
'uploader': meta.get('username'), | ||
'duration': meta.get('duration'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float_or_none
.
'uploader': meta.get('username'), | ||
'duration': meta.get('duration'), | ||
'thumbnail': meta.get('thumbnail'), | ||
'webpage_url': meta.get('link'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Adds an extractor for cinemagraphs from Flixel's gallery. One example of valid URL is
https://flixel.com/cinemagraph/esgyxix95j55m9f6ptp9/
.