Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flixel] Add new extractor #14899

Closed
wants to merge 1 commit into from

Conversation

olivierguerriat
Copy link

@olivierguerriat olivierguerriat commented Dec 3, 2017

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Adds an extractor for cinemagraphs from Flixel's gallery. One example of valid URL is https://flixel.com/cinemagraph/esgyxix95j55m9f6ptp9/.

return {
'id': video_id,
'title': meta.get('caption'),
'url': meta.get('hd_mp4'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More video qualities are available.

meta = self._download_json(json_url, video_id)
return {
'id': video_id,
'title': meta.get('caption'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title is mandatory.

'title': meta.get('caption'),
'url': meta.get('hd_mp4'),
'uploader': meta.get('username'),
'duration': meta.get('duration'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float_or_none.

'uploader': meta.get('username'),
'duration': meta.get('duration'),
'thumbnail': meta.get('thumbnail'),
'webpage_url': meta.get('link'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible pending-fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants