[ruv] Add new extractor #13396
Closed
[ruv] Add new extractor #13396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Jun 15, 2017
youtube_dl/extractor/ruv.py
Outdated
|
|
||
| title = self._og_search_title(webpage) | ||
| self.report_extraction(video_id) | ||
| video_url = self._html_search_regex(r'video.src\s+=\s+["\'](.+?)["\']', webpage, u'video URL') |
There was a problem hiding this comment.
Dots should be escaped. Regex should be relaxed. No u''.
youtube_dl/extractor/ruv.py
Outdated
| webpage = self._download_webpage(url, video_id) | ||
|
|
||
| title = self._og_search_title(webpage) | ||
| self.report_extraction(video_id) |
orng
force-pushed
the
ruv
branch
2 times, most recently
from
cde8821
to
2a40a89
Compare
|
Thanks for the comments. I believe I have addressed them all in the two commit above. I have no idea why some of the tests are failing though, but as far as I can tell it's due to some issue unrelated to my changes, is that correct? |
dstftw
requested changes
Jun 18, 2017
youtube_dl/extractor/ruv.py
Outdated
|
|
||
|
|
||
| class RuvIE(InfoExtractor): | ||
| _VALID_URL = r'http?://(?:www\.)?ruv\.is/sarpurinn/ruv/\w+/(?P<id>[0-9]+)' |
|
Squash commits. |
|
I addedthe missing s in "http?" (should be "https?") in url regex and rebased into one commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Added new extractor for Icelandic national TV station Rúv's website ruv.is. In particular, ruv.is/sarpurinn which is where most shows are made available online.