Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows setup via chocolatey repository #12406

Closed
wants to merge 1 commit into from
Closed

Windows setup via chocolatey repository #12406

wants to merge 1 commit into from

Conversation

majkinetor
Copy link

Added note in README.md about installation using Chocolatey repository (similar as Homebrew on OS X).

I am one of the package maintainers and we keep the package up to date automatically as can be seen in package versions on the Chocolatey gallery

https://chocolatey.org/packages/youtube-dl

@dstftw
Copy link
Collaborator

dstftw commented Mar 8, 2017

Using official binary on Window is preferred.

@dstftw dstftw closed this Mar 8, 2017
@majkinetor
Copy link
Author

majkinetor commented Mar 8, 2017

It is official binary, as always on Chocolatey (compare the checkusum).

You can take a look at the source code of the package automatic updater:

https://github.com/chocolatey/chocolatey-coreteampackages/blob/master/automatic/youtube-dl/update.ps1

The lines of interest are:

$domain   = 'https://github.com'
$releases = "$domain/rg3/youtube-dl/releases/latest"

On our update report you can see the acutall URL that is used to embed the binary into the package:

youtube-dl - checking updates using au version 2017.3.8.195050
URL check
  https://github.com/rg3/youtube-dl/releases/download/2017.03.07/youtube-dl.exe
nuspec version: 2017.03.07
remote version: 2017.03.07
No new version found

@majkinetor
Copy link
Author

majkinetor commented Mar 8, 2017

In the package creation process, there is nothing else done with the exe file. Package provides metadata about the tool only and it is a standard nuget package used on Windows platform.

@dstftw
Copy link
Collaborator

dstftw commented Mar 8, 2017

I mean I don't see any point mentioning just another 3rdparty repo especially before the official exe.

@majkinetor
Copy link
Author

Whatever you choose really is fine by me. And like I said, it is official exe, just packed in convenient way that can be used to quickly upgrade it (along with other tools on Windows), pinpoint particular version etc and be used with other popular repository tools such as Nexus or Artifactory in a local offline proxy.

There is no difference between choco and homebrew tho and it is mentioned, that is why I thought it is a good idea.

@majkinetor
Copy link
Author

One other important thing, it automatically installs dependency, vcredist 2010, so it will reduce issues for Windows users.

@yan12125
Copy link
Collaborator

yan12125 commented Mar 9, 2017

I think it‘s not bad to mention another installation method if:

  1. It's always kept up to date
  2. The update process contains client-side GPG key verification. I didn't see GPG related stuffs in your links. Could you give some more info?
  3. It's mentioned as an alternative after the official binary. You may argue that it makes users' life easier, but we don't want to put things that we have no control first.

@majkinetor
Copy link
Author

majkinetor commented Mar 9, 2017

@yan12125

  1. Yes, it is always kept up to date up to few hours. Our bot runs minimum every 6 hours and regularly more then that so the update happens with maximum few hours latency then released here. As you can see on repology there are only 4 repositories that keep youtube-dl up to date and choco is one of them.
  2. The client side does checksum checking and GPG code sign is planned in the future (@ferventcoder, can tell more about it). The server side also does virustotal checking.
  3. I simply followed the method you used for homebrew. I changed the README to put official windows install before chocolaty.

@majkinetor
Copy link
Author

It looks now like this (commit wasn't shown here because PR is closed):


Windows users can download an .exe file and place it in any location on their PATH except for %SYSTEMROOT%\System32 (e.g. do not put in C:\Windows\System32).
Alternatevelly, you can also install and upgrade youtube-dl via Chocolatey repository:

choco install youtube-dl

@yan12125
Copy link
Collaborator

yan12125 commented Mar 9, 2017

Thanks for the answers. Do you have a link to an issue/a ticket for GPG stuffs in your packaging system? When it's done, we can revisit this change.

@majkinetor
Copy link
Author

chocolatey/choco#504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants