-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils.py: Workaround TypeError with Python 2.7.13 in Windows #12085
Conversation
Thanks for opening this. How many Python versions have you tested? |
Well, the TypeError only triggers with Windows, so I tested with 2.7.12 (clean install), which triggered the |
It's less likely to break existing codes than the |
Fixes #11540 Tested with Windows Python 2.7.12 and 2.7.13.
Ran |
Should I open a issue asking for the official builds to switch to using Python 2 instead of 3.4.4? |
The fix would only need to be more involved were LoadLibrary be needed for a Windows lib, but this is the only use of it in Youtube-DL. |
Official builds won't switch to python 2 since this brings encoding issues. Actually switch to python 3 from python 2 has taken place due to this. |
So the only fix for official builds with SSL errors is to use |
Most of the SSL errors reported are due to expired certificates in system store removing which fixes the problem. |
There's no expired certificates on my system store and I can consistently reproduce the SSL errors with 3.4.4. If there were issues with expired certificates wouldn't the error also happen with every other Python version? |
There are tons of reasons leading to SSL failures; that's why I propose http://bugs.python.org/issue28182 |
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Fixes #11540
More exactly it's a workaround, not a fix, but people shouldn't be forced to use a months old version just because of a TypeError in a LoadLibrary that isn't even relevant in Windows.
Also recommend using Python2 for the official builds, since using 3.4.4 (more than a year old) is probably one of the bigger reasons why this error is so prevalent in Windows lately.