[openload] Fix extraction.

[kasper93]

Before submitting a pull request make sure you have:

• At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
• Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Bug fix
• Improvement
• New extractor
• New feature

---

They changed "decryption" code a little. Here is current one.

var y = $("#yJ7n4OuuU7").text();
var magic = y.slice(-1).charCodeAt(0);
y = y.split(String.fromCharCode(magic - 1)).join("  ");
y = y.split(y.slice(-1)).join(String.fromCharCode(magic - 1));
y = y.split("   ").join(String.fromCharCode(magic));
var s = [];
for (var i = 0; i < y.length; i++) {
  var j = y.charCodeAt(i);
  if ((j >= 33) && (j <= 126)) {
    s[i] = String.fromCharCode(33 + ((j + 14) % 94));
  } else {
    s[i] = String.fromCharCode(j);
  }
}
var tmp = s.join("");
var str = tmp.substring(0, tmp.length - 1) + String.fromCharCode(tmp.slice(-1).charCodeAt(0) + 2);

They've added (funny code if you ask me)

var magic = y.slice(-1).charCodeAt(0);
y = y.split(String.fromCharCode(magic - 1)).join("  ");
y = y.split(y.slice(-1)).join(String.fromCharCode(magic - 1));
y = y.split("   ").join(String.fromCharCode(magic));

I wonder what they are trying to achieve by doing such stupid obfuscation.

I adopted those changes, let's see how long it will be working this time :)

Fixes #10408

[yan12125]

You are SOOOOO fast :-)

[dstftw]

@yan12125 FYI there are Rebase and merge and Squash and merge auto options available in GitHub merge interface for quite some time already which don't introduce merge commit keeping git log cleaner.

[yan12125]

@dstftw Thanks I know those options. My personal preferences is keeping commit IDs unchanged across repositories. For example kasper93@60633ae is landed as 60633ae. This introduces fewer surprises when tracing the history.
PS: I admit it's more a mercurial mindset than a git one. If you think merge commits are too noisy I can change my convention in youtube-dl.