-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation Date / Uploaders Date #8
Comments
No, sorry, the epoch is taken from the current time in your computer. I'll think about the upload date. |
Originally by anonymous: I'd also like to see this feature -- for instance when downloading a series of videos which aren't otherwise numbered. |
Originally by "XulChris": Hi, please add this feature. I'm downloading a user's channel which has hundreds of videos and I would like them sorted in upload order. I would like to be able to use -o to specify a date/time format like YYYYMMDDHHMMSS Thanks. |
I will have a look at implementing this. Only the upload date is specified not the time. I will make sure though. Regarding date format, it is possible to implement using strftime() notation. eg. '%Y%m%d' for YYYYMMDD, but the output format sequence needs to contain a name eg %(upldate)s, else parsing it will become unnecessarily complicated. So perhaps if we set it to YYYYMMDD as the default it should be fine for chronological ordering? |
If they upload a video the same day, the order may not be preserved, but it may be fine for some users. Edit: BTW, yes, in that case the reasonable option is YYYYMMDD. The template text could be "uploaddate", no need to shorten it. |
I will only be adding this to YoutubeIE for the time being. I will set the uploaddate to u'NA' for the other IEs. |
Ok. That's a good start. As you said first, this is a general template parameter, so it should either be added to all IEs or set to NA. Ideally, the date would be extracted from any site that provides the information. |
I had to rewrite your code for "uploaddate" because it failed in my tests. By the way, I renamed the template parameter to "upload_date" after noticing there was already a "player_url" FD parameter, so as to be consistent. Anyway, the problem is now solved. |
Hi, sorry I'm only replying now. I made a silly mistake in the code I commited when I refactored. Really sorry about that! Please view the comments I've made on the lines in your commit 138b11f (138b11f#commitcomment-201370). No probs with "upload_date" :-) |
I've read the comments. You don't see dates in other languages because youtube-dl sets the language in YouTube prior to downloading the first video. That's why you see the line "[youtube] Setting language". Your method would appear to work here. I'll fully review it one of these days and may revert back to it, if just because it's better if I get rid of that month table. |
Hehehe ok cool. I will rebase against the current master and make sure the code is correct so it's easier for you to review. I will do it on another branch in my repo perhaps. We can also generate a list of locale based month names like so :
|
That would be great. Just redo your changes (yes, using another branch to implement the feature is a great idea). I'll pull your changes when they are ready. I'll also notify you of any problems while testing it, so you can fix the code before I merge it. There's no need to generate the month names if parsing the date with strptime works. Looking forward to your pull request. |
It would be great if I could obtain this uploadDate info with a flag instead of having to download the video for its filename or parse the json with an external tool. |
Authored by GreyAlien502
Was: http://bitbucket.org/rg3/youtube-dl/issue/159/
Is it possible to include the uploaders Date to the filename. The epoch option is the download date?
The text was updated successfully, but these errors were encountered: