-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for socks5h:// proxies #22618
Labels
Comments
11 tasks
8 tasks
9 tasks
pukkandan
pushed a commit
to pukkandan/yt-dlp-dev
that referenced
this issue
Jul 15, 2023
New networking interface consists of a `RequestDirector` that directs each `Request` to appropriate `RequestHandler` and returns the `Response` or raises `RequestError`. The handlers define adapters to transform its internal Request/Response/Errors to our interfaces. User-facing changes: - Fix issues with per request proxies on redirects for urllib - Support for `ALL_PROXY` environment variable for proxy setting - Support for `socks5h` proxy - Closes yt-dlp#6325, ytdl-org/youtube-dl#22618, ytdl-org/youtube-dl#28093 - Raise error when using `https` proxy instead of silently converting it to `http` Authored by: coletdjnz
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this issue
Apr 21, 2024
New networking interface consists of a `RequestDirector` that directs each `Request` to appropriate `RequestHandler` and returns the `Response` or raises `RequestError`. The handlers define adapters to transform its internal Request/Response/Errors to our interfaces. User-facing changes: - Fix issues with per request proxies on redirects for urllib - Support for `ALL_PROXY` environment variable for proxy setting - Support for `socks5h` proxy - Closes yt-dlp#6325, ytdl-org/youtube-dl#22618, ytdl-org/youtube-dl#28093 - Raise error when using `https` proxy instead of silently converting it to `http` Authored by: coletdjnz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Description
The difference between SOCKS5 and SOCKS5H is that SOCKS5H resolves DNS requests through the proxy and SOCKS5 resolves them locally. The DNS leak has technically been addressed in #9677 and it appears to been removed based on tests I carried out sniffing for DNS packets while running youtube-dl with
--proxy socks5://
(this is the relevant line, I think).So
youtube-dl --proxy socks5://
behaves howyoutube-dl --proxy socks5h://
should behave, and the latter misbehaves:I suggest that youtube-dl should accept the
socks5h
protocol and use for it the implementation of SOCKS5 that already exists (where DNS is resolved by the SOCKS server).And maybe
socks5
's implementation should be changed to resolve DNS locally to honour the specification. The only issue I can see with fixing the names of the protocols is any scripts withsocks5://
in them will start leaking DNS requests.The text was updated successfully, but these errors were encountered: