Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Full resolution SoundCloud artwork download #19071

Closed
4 tasks done
AwesomeAwesomeAwesome opened this issue Jan 30, 2019 · 4 comments
Closed
4 tasks done

Comments

@AwesomeAwesomeAwesome
Copy link

  • I've verified and I assure that I'm running youtube-dl 2019.01.30.1
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Feature request (request for a new functionality)

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included:


SoundCloud provides for most of its tracks a high resolution artwork

And it's extremely easy to access! You simply need to replace the -t500x500 part of the url with original or in some very rare cases with original size.

There already exists a script that adds a download button for every artwork (https://greasyfork.org/en/scripts/14591-soundcloud-album-art-downloader), however there is no way to automatise it.

An additional handle to force download full/original size artwork would simplify the process.

@davidchalifoux
Copy link

I was just about to make this request, thanks for putting it in!
I too would really like to see this added.

@Romern
Copy link

Romern commented Mar 17, 2019

This is already possible, by using the --embed-thumbnail flag, and editing the thumbnail url:

--- a/youtube_dl/extractor/soundcloud.py
+++ b/youtube_dl/extractor/soundcloud.py
@@ -218,7 +218,7 @@ class SoundcloudIE(InfoExtractor):
             self.report_extraction(name)
         thumbnail = info.get('artwork_url') or info.get('user', {}).get('avatar_url')
         if isinstance(thumbnail, compat_str):
-            thumbnail = thumbnail.replace('-large', '-t500x500')
+            thumbnail = thumbnail.replace('-large', '-original')
         username = try_get(info, lambda x: x['user']['username'], compat_str)
 
         def extract_count(key):

However, I am not sure if it should be made permanent, I would prefer an option for choosing the thumbnail quality.

EDIT: I just tried it on a huge amount of tracks, and out of 897 tracks, 48 did not have an original sized thumbnail, so it is not always available.

@pyxelr
Copy link

pyxelr commented Dec 10, 2019

@AwesomeAwesomeAwesome @RomanKarwacik:
I would also prefer to choose between original / 500x500 size. The original is too large for my requirements, hence significantly increases the file size.
Is there some easy way to specify the dimensions of the thumbnail in youtube-dl?

@pyxelr
Copy link

pyxelr commented Jan 5, 2020

@AwesomeAwesomeAwesome @RomanKarwacik:
I would also prefer to choose between original / 500x500 size. The original is too large for my requirements, hence significantly increases the file size.
Is there some easy way to specify the dimensions of the thumbnail in youtube-dl?

Problem solved.
It simply required to modify a single line of soundcloud.py:
elif image_id == 'original': into elif image_id == 't500x500':

meunierd referenced this issue in meunierd/youtube-dl Feb 13, 2020
- improve format extraction(closes #22123)
- extract uploader_id and uploader_url(closes #21916)
- extract all known thumbnails(closes #19071)(closes #20659)
- fix extration for private playlists(closes #20976)
- add support for playlist embeds(#20976)
- skip preview formats(closes #22806)
pareronia referenced this issue in pareronia/youtube-dl Jun 22, 2020
- improve format extraction(closes #22123)
- extract uploader_id and uploader_url(closes #21916)
- extract all known thumbnails(closes #19071)(closes #20659)
- fix extration for private playlists(closes #20976)
- add support for playlist embeds(#20976)
- skip preview formats(closes #22806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants