Skip to content

Commit

Permalink
[soundcloud] improve extraction
Browse files Browse the repository at this point in the history
- improve format extraction(closes #22123)
- extract uploader_id and uploader_url(closes #21916)
- extract all known thumbnails(closes #19071)(closes #20659)
- fix extration for private playlists(closes #20976)
- add support for playlist embeds(#20976)
- skip preview formats(closes #22806)
  • Loading branch information
remitamine authored and meunierd committed Feb 13, 2020
1 parent d0d98d6 commit a0e5957
Show file tree
Hide file tree
Showing 3 changed files with 249 additions and 257 deletions.
1 change: 1 addition & 0 deletions youtube_dl/extractor/extractors.py
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,7 @@
from .sohu import SohuIE
from .sonyliv import SonyLIVIE
from .soundcloud import (
SoundcloudEmbedIE,
SoundcloudIE,
SoundcloudSetIE,
SoundcloudUserIE,
Expand Down
6 changes: 3 additions & 3 deletions youtube_dl/extractor/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
from .kaltura import KalturaIE
from .eagleplatform import EaglePlatformIE
from .facebook import FacebookIE
from .soundcloud import SoundcloudIE
from .soundcloud import SoundcloudEmbedIE
from .tunein import TuneInBaseIE
from .vbox7 import Vbox7IE
from .dbtv import DBTVIE
Expand Down Expand Up @@ -2749,9 +2749,9 @@ def _real_extract(self, url):
return self.url_result(myvi_url)

# Look for embedded soundcloud player
soundcloud_urls = SoundcloudIE._extract_urls(webpage)
soundcloud_urls = SoundcloudEmbedIE._extract_urls(webpage)
if soundcloud_urls:
return self.playlist_from_matches(soundcloud_urls, video_id, video_title, getter=unescapeHTML, ie=SoundcloudIE.ie_key())
return self.playlist_from_matches(soundcloud_urls, video_id, video_title, getter=unescapeHTML)

# Look for tunein player
tunein_urls = TuneInBaseIE._extract_urls(webpage)
Expand Down
Loading

0 comments on commit a0e5957

Please sign in to comment.