-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[youtube:playlist] Fetch all the videos in a mix (fixes #3837)
Since there doesn't seem to be any indication, it stops when there aren't new videos in the webpage.
- Loading branch information
Showing
2 changed files
with
21 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b6182d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still does not download all the videos. I'm getting completely different results in browser with any mix.
1b6182d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I got that behaviour on Firefox but then I tried on Safari and when it reached https://www.youtube.com/watch?v=Sb5aq5HcS1A&index=51&list=RDSBjQ9tuuTJQ it starts again with the first video. I'm pretty sure I tested again on Firefox and see the same behaviour, so I assumed it was an error on YouTube side. But now both on Firefox and Chrome the list doesn't seem to contain duplicates and continues (in Safari it's still limited to 51 videos). To be honest I don't know why it's that. In the case of youtube-dl, maybe adding the appropriate
&index
to the url may help (although we'll need to handle an infinite playlist).