[ENH] RAMSES: set max_level from parameter file #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to, e.g. create a sphere object without ever reading most of the AMR file
cphyc
commented
Nov 20, 2024
| @max_level.setter | ||
| def max_level(self, value): | ||
| self._max_level = value | ||
| return self.ds.max_level |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
RAMSES contains a text file that describes some basic element of the AMR structure, including the maximum level of refinment. However, that level may not be reached. Up to this PR, we would read all AMR domain files to figure out to effective max level of refinment. This is however a costly operation for large simulations; this PR returns a more conservative number for the max level (the highest achievable by the sim) and is MUCH faster.
PR Checklist