-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH actions workflow to check PR title and labels #4902
base: main
Are you sure you want to change the base?
Conversation
Thank you ! As I said on slack, I'm all for migrating away from this bot (as well as the WIP bot), but we need a code owner to actually remove them. This PR should not be merge before then, let's ping @matthewturk and @Xarthisius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure the mergeable bot was disabled -- so I think this one can be merged now. I'll also add/remove some labels to double check...
oh. hmm. mergeable is still running. oops. not sure why I thought we had disabled it :) |
ah, clarification from @Xarthisius : mergeable bot is still running but is no longer required for merge, which is where it was hanging. |
If the bot isn't blocking anymore, I'm not sure we need a replacement. I'll let you guys be the judges ! |
this needs a rebase |
5a233bb
to
917722a
Compare
I've updated this to also check for "WIP" in the PR title, which is the other thing the mergeable bot was checking. |
PR Summary
This replaces the mergeable bot, which has been flaky recently. I've tested it thoroughly at yut23#2, and it works as expected.
PR Checklist