TST: (temporary) pin scipy in image tests #4541
Conversation
|
Seems like this indeed fixes image tests, though it's not clear wether the problem is a pure regression in scipy, or an incompatibility in cartopy. Until we know who to upstream this discussion to, I advise not the merge this. |
|
Code inspection narrows it down to scipy/scipy#18502 |
neutrinoceros
force-pushed
the
exp_pin_scipy
branch
from
5d5bfd6
to
ef4b4e1
Compare
|
I added a link to the upstream issue SciTools/cartopy#2199 AFAIC this may now be merged to unblock other PRs. |
neutrinoceros
changed the title
There was a problem hiding this comment.
Looks good, but can you open a new issue to track the cartopy issue? Or not close the existing one until we see some discussion upstream? I don't think we want to pin scipy in yt's dependencies, since this bug will only affect those with the latest scipy and using cartopy (so this PR is totally sufficient as is)... but we might want to pin cartopy to the newest version once they release a fix for the issue.
|
Fair point, let's unlink the issue for now |
|
The discussion seem to be headed to a compatibility fix in cartopy with their next release, so things are looking good for this patch to play its role and remain a temporary workaround, I'll merge it so other PRs can move forward. |
PR Summary
Context: #4540
Scipy 1.11 was released 16hrs ago, so it's my number one suspect at the moment.
This PR is an attempt to narrow it down.