Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: upgrade mypy (0.991 -> 1.0.0) #4329

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

neutrinoceros
Copy link
Member

PR Summary

This is a noop PR to celebrate mypy going out of beta.
The 1.0.0 release is advertised as 40% faster than 0.991 (which I was able to verify in the case of yt), so even without using new features it still brings something to the table.
A feature I've been waiting for also has landed in this version (Support for Self type), though I'd prefer leveraging it in a following PR.

I'm also adding a workflow_dispatch trigger to the type-checking workflow, which was useful for me to test the upgrade on my fork.

@neutrinoceros neutrinoceros added enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc labels Feb 8, 2023
@matthewturk
Copy link
Member

Yay! 🎆

@neutrinoceros neutrinoceros marked this pull request as ready for review February 8, 2023 12:05
@matthewturk matthewturk merged commit bc825c4 into yt-project:main Feb 10, 2023
@neutrinoceros neutrinoceros deleted the upgrade_mypy branch February 10, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants