MNT: bump minimal required IPython version from 1.0.0 to 2.0.0 #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support for use_2to3=True flag was dropped in setuptools 58.0.0
neutrinoceros
added
blocker
Xarthisius
approved these changes
Sep 8, 2021
neutrinoceros
changed the title
|
Looks good to me. I see no reason not to merge, so will do so. |
|
@meeseeksdev backport to yt-4.0.x |
|
@meeseeksdev hello |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Oct 15, 2021
…on from 1.0.0 to 2.0.0
|
Helloooo @neutrinoceros, I'm Mr. Meeseeks! Look at me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This replaces #3504 (see therein for details), and fixes our remaining CI failures that weren't resolved upstream.
Explanation: setuptools 58.0 dropped support for the
use_lib2to3=Trueflag, used to convert Python 2 code to Python 3 at build time, seeExactly one of our dependencies is broken by this change, namely: IPython 1.0.0 (released on August 2013)
The earliest version of IPython that is still supported by the latest version of setuptools is 2.0.0 (released on April 2014), so I assume it is reasonable to just bump our minimal supported version and call it a day.