Support loading json unit registries produced by yt.units #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jzuhone
approved these changes
Jun 26, 2019
brittonsmith
approved these changes
Jun 27, 2019
|
I think we can merge this, right? |
|
Yes I’ve been busy with job interviews and had time to come back to this yet. |
|
Wow, I didn't notice this till just now! Thanks, @ngoldbaum ! This is great. And good luck with interviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully unblock yt-project/yt#2219 once this is merged and we cut a new release yt can depend on. Ping @brittonsmith.
While working on this I found a bug in our definition of light year, it looks like when we went from using CGS base values to MKS the correction to the value of light year didn't go in the correct direction, leaving us off by a factor of 10,000 (100 squared).
Note that we need some minor changes on the yt side (which I have staged already but this needs to be merged first) to fully support loading old ytdata outputs.