Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues working with code units #78

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

ngoldbaum
Copy link
Member

This fixes some issues I found trying to get unyt working with yt. First, it adds an explicit test for a code unit system like yt's. It also makes sure that custom units will show up in a unit container object like i've created in yt via ds.units, to make sure that things like ds.units.code_length will work as expected. I also added a new has_current_mks property on the UnitSystem class that I found useful in the process of getting yt working with unyt.

@ngoldbaum ngoldbaum requested a review from jzuhone March 26, 2019 16:31
@ngoldbaum ngoldbaum merged commit 102c2da into yt-project:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant