blacken the codebase #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love this! |
matthewturk
approved these changes
Jan 8, 2019
|
OK tests are all passing now. @jzuhone would you mind doing the honors if you're ok with everything? |
|
(I dropped python3.4 testing because numpy just dropped support as well) |
jzuhone
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formats the codebase with black, a formatter for python code. Overall I'm happy with most of the changes it made. There are a few places where it makes things less clear but I think that's worth it for the automation and lack of need to fight about formatting in the future.
I've added a test for black and have ignored a couple of flake8 rules as suggested in the black docs. I've also increased the max line length to 88 characters.
I'm happy to bikeshed on this stuff, however black has few configuration knobs (on purpose) so there's not much I can do to control the formatting output.