Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: adjust doctests to changes in array repr from numpy 2.0 #506

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jun 17, 2024

A couple non-user facing adjustments to numpy 2.0

example logs

@neutrinoceros
Copy link
Member Author

I don't get why CI is red yet. Even on the failing job it looks like all tests passed. Let me give it another try before I dive into this potential rabbit hole.

@neutrinoceros
Copy link
Member Author

I see GitHub Actions re-released several Python binaries in the last couple days, so let's try again just again the problem is already resolved.

@neutrinoceros
Copy link
Member Author

Alright, new problem: now Windows is failing because it doesn't yet get to install numpy 2. This is caused by the latest version of astropy (6.1.1) pinning numpy<2.0 specifically on windows (and I'm really glad I authored this pin, otherwise I'm not sure I would have found out)
I also know this will be resolved in astropy 6.1.2 (coming soon), and that 6.1.0 didn't have the pin at all. Since I don't think astropy bugs discovered/patched since 6.1.0 actually affect unyt I'm just going to try and exclude 6.1.1 and see how it goes.

@neutrinoceros
Copy link
Member Author

turns out I was just not scanning logs correctly and there was an actual failure on Python 3.9 with minimal supported numpy. Trying to fix this now.

@neutrinoceros neutrinoceros marked this pull request as ready for review June 21, 2024 09:24
@jzuhone jzuhone merged commit f32aa36 into yt-project:main Jun 26, 2024
9 checks passed
@neutrinoceros neutrinoceros deleted the doc/numpy2_repr branch June 26, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants