Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REL: prepare release 2.9.5 #372

Merged
merged 4 commits into from
Feb 23, 2023
Merged

REL: prepare release 2.9.5 #372

merged 4 commits into from
Feb 23, 2023

Conversation

neutrinoceros
Copy link
Member

backports #371

This was discussed with @ngoldbaum in the aforementioned PR, but given how fast this move has been, I will wait for an explicit approval before moving this forward.

(in particular: ping @jzuhone)

@neutrinoceros
Copy link
Member Author

given the unusual activity the issue tracker is going through, it's probably best to hold this off for a day or two, in case we want to ship additional fixes.

@neutrinoceros
Copy link
Member Author

I forgot to bump the version number, will do later today when I'm able to merge and backport #375

@neutrinoceros
Copy link
Member Author

I forgot unyt's version number was built from the git tag, so no need for a manual bump.
Anyway, #375 is now included in this PR.
ping @ngoldbaum and @jzuhone for validation.

@neutrinoceros neutrinoceros force-pushed the prep_rel_2.9.5 branch 2 times, most recently from 3454a5c to b2cf4c6 Compare February 23, 2023 15:07
@neutrinoceros
Copy link
Member Author

⚠️ Important notice: #375 breaks a couple tests in yt (see https://github.com/yt-project/yt/actions/runs/4254771560)
in all cases, dimensionless scalars seem to be involved. Personally I think it's still fine to release the patch and address the incompatibilities downstream, but this warrants a discussion.

@neutrinoceros
Copy link
Member Author

This now includes #376, resolving the issue from my previous comment. I'm running yt's CI again at https://github.com/yt-project/yt/actions/runs/4256539239

@ngoldbaum ngoldbaum merged commit d625b71 into yt-project:v2.9.x Feb 23, 2023
@neutrinoceros neutrinoceros deleted the prep_rel_2.9.5 branch February 23, 2023 22:20
@neutrinoceros neutrinoceros mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @ngoldbaum