ENH: (NEP 18) implement numpy.savetxt #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the first run failed with "did not warn", but I think that's just because warnings are filtered with |
|
more tweaking needed, I'll come back to this later today |
ngoldbaum
approved these changes
Nov 22, 2022
|
It is |
|
Oops sorry I thought it was a different PR. I was planning to wait on #324 but you can merge this first if you'd like |
|
Can you fix the conflicts? |
neutrinoceros
force-pushed
the
nep18_savetxt
branch
from
5fdbed7
to
0e377b0
Compare
|
@ngoldbaum done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for context, see discussion in #289, starting in #289 (comment)
opening as a draft because it will inevitably conflict with #324