ENH: (NEP 18) implement scalar reducer functions, add tests for array reshaper functions #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
nep18_reshapers
branch
from
fb1e05f
to
cfb4667
Compare
ngoldbaum
reviewed
Nov 12, 2022
| np.nansum, # works out of the box (tested) | ||
| np.product, # is implemented via np.prod | ||
| np.std, # works out of the box (tested) | ||
| np.nanstd, # works out of the box (tested) |
There was a problem hiding this comment.
It occurs to me it would be nice to write tests for all these. Something to think about for future PRs.
There was a problem hiding this comment.
argh sorry i misread the rest of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.