ENH: (NEP 18) test 7 new functions, impl 2 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
nep18_4
branch
from
eeb1804
to
32151fb
Compare
neutrinoceros
commented
Oct 19, 2022
| def get_units(arrays): | ||
| units = [] | ||
| for sub in arrays: | ||
| if isinstance(sub, np.ndarray): |
There was a problem hiding this comment.
this check is not as general as it should, we need to capture all non-nested arraylike objects here, which is a bit tricky
There was a problem hiding this comment.
actually I'll take that back. np.ndarray instances are the only objects for which we know that we can grab a single unit without iterating over each elements.
This implementation will probably be dramatically slow when nested lists of quantities are passed but hey, I guess users shouldn't be doing that at scale and expect the very best of performances, so all in all this seems reasonable to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.