Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: implement 8 new NEP 18 functions #293

Merged
merged 9 commits into from
Oct 12, 2022
Merged

ENH: implement 8 new NEP 18 functions #293

merged 9 commits into from
Oct 12, 2022

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Oct 11, 2022 •
edited
Loading

implements #289 (comment)

TODO:

  • get CI green for existing tests
  • add new tests

@neutrinoceros neutrinoceros mentioned this pull request Oct 11, 2022
Closed
@neutrinoceros neutrinoceros marked this pull request as ready for review October 11, 2022 20:12
ngoldbaum
ngoldbaum reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for plugging at this. Mostly looks good but I have a couple places I need clarification.

tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
unyt/_array_functions.py Outdated Show resolved Hide resolved
unyt/array.py Show resolved Hide resolved
@ngoldbaum ngoldbaum merged commit 40c0747 into yt-project:main Oct 12, 2022
@neutrinoceros neutrinoceros deleted the nep18_2 branch October 12, 2022 22:18
This was referenced Oct 13, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @ngoldbaum