store SI-prefixability metadata in the unit registry #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than keeping a global list of units that can be SI-prefixed, let's store that data in the unit registry. That means adding that data to the units in the default unit symbol lookup table. It also means adding the ability to add new SI-prefixed units to a unit registry. It was already possible to do that globally via
define_unit
, now it's possible to do it just for a single unit registry.This makes it easier to use unyt as a library without messing with unyt's internals. It also eliminates one vector for cross-library interference by no longer having as much global state.
I found this while porting yt.units to use unyt under the hood.