BUG: fix unit conversion for array with dtype int8 #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dtype was apparently overlooked in PR #56
fails with
the root cause is that
float8
dtype doesn't exist. The fix is to force minimalitemsize
in bytes to 2, rather than copying it directly from the input dtype, so input array with dtypeint8
gets converted tofloat16
.While I'm at it I also patched
unyt_array.convert_to_units
so that it raises a clearer error message in case the user attempts to convert aint8
array in place (which isn't possible, I think)