Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional line in tox for python 3.8 #150

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

migueldvb
Copy link
Contributor

@migueldvb migueldvb commented Apr 14, 2020

@ngoldbaum I added a conditional line in the tox configuration to run the unyt.test() function for python3.8 (https://tox.readthedocs.io/en/latest/config.html#factors). It seems to work fine on my local environment.

@ngoldbaum
Copy link
Member

Sorry to nitpick, but can you make this a separate test job, e.g. py38-unyt-module-test-function? I think having it only on this one line in the general build command will make it less clear that the failure ultimately comes from calling unyt.test(). If it’s its own test job it will be much more clear from the tox output and the name of the job that failed where the failure comes from.

@migueldvb
Copy link
Contributor Author

got you! I have added a separate test environment for the unyt.test function
on python 3.8 that depends on the py38 environment so that they will share the
same dependencies instead of duplicating the same information under the two
tests. It works when both environments are run together or separately. Does
it look good like this?

@ngoldbaum
Copy link
Member

Looks good! Thank you for working on this :)

@ngoldbaum ngoldbaum merged commit 466b25a into yt-project:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants