Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unyt_arrayConverter to handle sequences of unyt types. #126

Merged
merged 14 commits into from
Jan 22, 2020
Merged

Update unyt_arrayConverter to handle sequences of unyt types. #126

merged 14 commits into from
Jan 22, 2020

Conversation

l-johnston
Copy link
Contributor

No description provided.

Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would also be useful to define a __call__ implementation that just unconditionally adds the converters to the registry so that people can turn it on like this:

import unyt
unyt.matplotlib_support()

And thereafter not need to use the context manager. Here I’m using my suggested name for MPLUnitsCM just to illustrate that it’s a little more convenient to not use a camel cased name.

Thank you so much for working on this so quickly and being so ready to help out. I’m very appreciative of the time and effort you are putting into this.

unyt/mpl_interface.py Outdated Show resolved Hide resolved
unyt/mpl_interface.py Outdated Show resolved Hide resolved
unyt/mpl_interface.py Outdated Show resolved Hide resolved
unyt/__init__.py Outdated Show resolved Hide resolved
unyt/__init__.py Outdated Show resolved Hide resolved
unyt/mpl_interface.py Outdated Show resolved Hide resolved
@ngoldbaum
Copy link
Member

There were some finicky documentation formatting issues I fixed in the last commit I just pushed. As soon as the tests pass I'm going to merge this. Thank you again for spending your time today on this.

@ngoldbaum ngoldbaum merged commit c2a4025 into yt-project:master Jan 22, 2020
@l-johnston l-johnston deleted the convert_sequences branch January 22, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants